New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Js component experiment #1158
Merged
Merged
Js component experiment #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ somehow fix it, I don't know why it works now...
This allows one to have catch all property group for both attributes and inner elements. It's used in JsComponent for templates and props, both with empty prefix
exyi
commented
Oct 27, 2021
...Samples/Common/Views/FeatureSamples/JsComponentIntegration/ReactComponentIntegration.dothtml
Outdated
Show resolved
Hide resolved
tomasherceg
reviewed
Oct 30, 2021
quigamdev
reviewed
Nov 3, 2021
src/Samples/Common/Views/FeatureSamples/ViewModules/Incrementer.dotcontrol
Show resolved
Hide resolved
exyi
force-pushed
the
js-component-experiment
branch
from
November 3, 2021 11:33
ecceab9
to
d2464f5
Compare
exyi
force-pushed
the
js-component-experiment
branch
from
November 3, 2021 11:37
d2464f5
to
ecceab9
Compare
Also fixed a bug in invoking a command with arguments from named command.
quigamdev
reviewed
Nov 3, 2021
exyi
commented
Nov 5, 2021
exyi
commented
Nov 5, 2021
exyi
commented
Nov 5, 2021
src/Tests/ControlTests/testoutputs/SimpleControlTests.NamedCommand.html
Outdated
Show resolved
Hide resolved
This could allow for more complex template usage
…dotvvm into js-component-experiment
…ackage for react integration
…dotvvm into js-component-experiment
The problem was that we ignored the user-specified context in static commands. Now we use options.knockoutContext only if no context is specified.
exyi
force-pushed
the
js-component-experiment
branch
from
November 7, 2021 14:27
ef0f3eb
to
c11ec1b
Compare
quigamdev
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.