New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HierarchyRepeater #1206
Add HierarchyRepeater #1206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rewrite this code to use the standard Item Template mechanism as Repeater uses.
Tbh we should completely rewrite this control.
What do you mean by standard item template mechanism? This control already uses the same mechanism as Repeater with the exception of the This method cannot be used since it generates the template id based on the hash of template's contents... which needs to contain the template id. This can be overcome in two ways: either by rendering the template twice -- once to obtain the id and once to put the id back in, or by generating the template id in some other way (as I did in this PR).
This is already pretty much a complete rewrite of |
aab8ece
to
54d129c
Compare
54d129c
to
33c4a5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I have found just minor issues.
It would be nice to have also some perf test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just noticed that unit tests are failing.
Limitation: |
There is currently no control in the framework able to render recursive hierarchies, so I backported
HierarchyRepeater
from business pack over here.Implementing any
ItemsControl
, let alone a repeater, is a mine field, so any feedback is very, very welcome.