Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IHeathCheck implementation to Asp.Net Core hosting #1209

Merged
merged 3 commits into from Apr 19, 2022
Merged

Add IHeathCheck implementation to Asp.Net Core hosting #1209

merged 3 commits into from Apr 19, 2022

Conversation

exyi
Copy link
Member

@exyi exyi commented Nov 7, 2021

The healthcheck just checks if dotvvm pages can be compiled.

resolves #1205

@exyi exyi requested a review from martindybal November 7, 2021 12:43
@exyi exyi added this to the Version 4.0 milestone Nov 7, 2021
@quigamdev
Copy link
Contributor

By internal comment from @martindybal we have some glitch there.

@martindybal
Copy link
Contributor

Yes, I reproted it to @exyi on Monday. It's not working when pages are not compile by StatusPage.

cafour
cafour requested changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@cafour cafour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the bug be resolved by keeping the metadata about the compilation (successful or failed) of each markup file in DefaultControlBuilderFactory instead of DotvvmViewCompilationService?

src/Framework/Hosting.AspNetCore/Hosting/DotvvmHealthCheck.cs Outdated Show resolved Hide resolved
@tomasherceg tomasherceg modified the milestones: Version 4.0, Version 4.1 Jan 5, 2022
@exyi exyi mentioned this pull request Jan 20, 2022
Closed
@exyi exyi requested review from cafour and a team February 26, 2022 15:58
@exyi exyi merged commit 4bbc325 into main Apr 19, 2022
@exyi exyi deleted the health-checks branch April 19, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acizmarik acizmarik acizmarik approved these changes

@cafour cafour cafour approved these changes

@martindybal martindybal Awaiting requested review from martindybal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 4.1
Development

Successfully merging this pull request may close these issues.

Add IHeathCheck implementation for Asp.Net Core
6 participants
@exyi @quigamdev @martindybal @acizmarik @cafour @tomasherceg