Dynamic data 2 - Auto UI #1293
Merged
Dynamic data 2 - Auto UI #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
dynamic-data-2
branch
2 times, most recently
from
c08c3ff
to
f6e5c73
Compare
acizmarik
reviewed
Jun 9, 2022
| return this; | ||
| } | ||
|
|
||
| public PropertyDisplayMetadataModifier Enable(bool allowEdit = true) |
There was a problem hiding this comment.
This feels a bit strange in connection with method EnableIfAuthenticated. The other method automatically sets the value to true. Either this one should behave similarly, or we should probably rename it to something more descriptive.
Suggested change
| public PropertyDisplayMetadataModifier Enable(bool allowEdit = true) | |
| public PropertyDisplayMetadataModifier SetAllowEditing(bool value = true) |
DynamicEntity sample also refactored
EnumComboBoxFormEditorProvider added
And fixed bugs in DynamicEditor sample
Concrete DynamicEntity type should be used instead.
Fix replacing of controls which don't allow children Fix styleContext.Property(c => c.P) for binding properties
Fixed issue in control tests
On dynamic data resource bindings it's actually not needed, but it was super annoying trying to make sure it's set correctly in grid, ...
…endering the corresponding fields
+ Configuration text output fixed because of new properties
acizmarik
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.