ClientID methods made public and allows specifying prefixes and suffixes #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should reimplement the methods returning |
exyi
reviewed
May 13, 2022
exyi
reviewed
May 21, 2022
exyi
force-pushed
the
feature/clientid-prefix-suffix
branch
from
1811f6d
to
0c5260b
Compare
exyi
force-pushed
the
feature/clientid-prefix-suffix
branch
from
0c5260b
to
10bb8d0
Compare
acizmarik
approved these changes
Jun 15, 2022
| @@ -90,32 +90,31 @@ public static void OnCompilation(ResolvedControl control, BindingCompilationServ | |||
|
|
|||
| control.SetProperty(new ResolvedPropertyBinding(Internal.CurrentIndexBindingProperty, | |||
| new ResolvedBinding(bindingService, new Compilation.BindingParserOptions(typeof(ValueBindingExpression)), dataContext, | |||
| parsedExpression: Expression.Parameter(typeof(int), "_index").AddParameterAnnotation( | |||
There was a problem hiding this comment.
This feels like an unnecessary change
exyi
force-pushed
the
feature/clientid-prefix-suffix
branch
from
0fbf896
to
f4f7aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.