Added support for more complex expressions to Validator.Value
#1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one more place where I need to fix this.
However, it is going to be separate PR as it is handled a bit differently there |
exyi
reviewed
Jun 3, 2022
src/Framework/Framework/Binding/Expressions/ValueBindingExpression.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Compilation/Binding/GeneralBindingPropertyResolvers.cs
Show resolved
Hide resolved
Created originally for DynamicEditor, but turns out it could also be used for some BP controls.
This makes it possible to bind, for example complex expressions, such as `DateProperty.ToBrowserLocalTime()`
…iscover the resolver
acizmarik
force-pushed
the
feature/validator-complex-expressions-reductions
branch
from
4aafa39
to
bb05eb5
Compare
exyi
approved these changes
Jun 4, 2022
Co-authored-by: Stanislav Lukeš <exyi@outlook.cz>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for complex expressions to
Validator.Value. I am not even sure, whether this is a new feature or a fix.In BusinessPack, controls automatically set their
Validator.Valueaccording to the passed value binding (e.g.DatePicker'sSelectedDate="{value: MyDateProperty}"generates knockout bindingdotvvm-validationwith valueMyDateProperty). However, this breaks once user tries to specify something more complex, for exampleMyDateProperty.ToBrowserLocalTime().ToString("yyyy").Therefore, this PR implements an unwrapping mechanism that tries to unwrap bindings so that errors can be propagated to the correct observable.