Basic support for working with enums client-side #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
client-side-enums
branch
3 times, most recently
from
48d5a8a
to
bf52f15
Compare
Added conversions from backing integer type to and from the enum string we use in view models. This means that binary operators on enums work the same way as in C# (+, &, |, ~). It should also fix #1302
Turns out this is bit hard to fix - Linq.Expression don't put there Constant(MyEnum.X) but convert one side of the comparison to int and then compare it with an int constant. We'll either have to add some magic rewriting rules to handle this case or add proper support for enum -> int conversions
exyi
force-pushed
the
client-side-enums
branch
from
b53acab
to
18dfddb
Compare
acizmarik
reviewed
Oct 5, 2022
acizmarik
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conversions from backing integer type to and from the enum string we use in view models.
This means that binary operators on enums work the same way as in C# (+, &, |, ~).
Also fixes #1302