Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile time warning for uppercase atrributes (i.e. mistyped properties) #1443

Merged
merged 1 commit into from Aug 10, 2022

Conversation

exyi
Copy link
Member

@exyi exyi commented Aug 4, 2022

We have this warning at runtime, so people can see it in the dev console,
or in ASP.NET Core logs. With this change, the error should be also
displayed in VS Extension (we currently don't display warnings with DotVVM itself)

We have this warning at runtime, so people can see it in the dev console,
or in ASP.NET Core logs. With this change, the error should be also
displayed in VS Extension (we currently don't display warnings with DotVVM itself)
@exyi exyi force-pushed the attribute-uppercase-warning branch from 96c3d35 to eb708c7 Compare August 4, 2022 21:19
Copy link
Member

@acizmarik acizmarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@acizmarik acizmarik merged commit 729d215 into main Aug 10, 2022
@acizmarik acizmarik deleted the attribute-uppercase-warning branch August 10, 2022 10:49
@exyi exyi added this to the Version 4.1 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants