Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed building query parameters in URL suffixes #1502

Merged
merged 3 commits into from Nov 2, 2022
Merged

Fixed building query parameters in URL suffixes #1502

merged 3 commits into from Nov 2, 2022

Conversation

acizmarik
Copy link
Member

This PR brings in bugfix first introduced by #1498. I did following changes:

  • Parameters with null values are skipped
  • Parameters with values equal to string.Empty are rendered without the = sign

@acizmarik acizmarik mentioned this pull request Nov 2, 2022
Merged
@acizmarik acizmarik merged commit aba45be into main Nov 2, 2022
@acizmarik acizmarik deleted the fix/query-parameters-null-values branch November 2, 2022 19:27
@acizmarik acizmarik added this to the Version 4.1 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exyi exyi exyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acizmarik @exyi