MemberExpressionFactory filters out private members #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't pass bindingFlags to the GetAllMembers method :| This bug was probably introduced in 4.0, but the fix will break any code depending on the behavior. However, I think it's quite unlikely many people would use private properties, since the serializer would ignore them.
acizmarik
approved these changes
Nov 30, 2022
exyi
force-pushed
the
fix/binding-private-members
branch
from
5f1206f
to
7c704eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't pass bindingFlags to the GetAllMembers method :|
This bug was probably introduced in 4.0, but the fix will break any code depending on the behavior. However, I think it's quite unlikely many people would use private properties, since the serializer would ignore them.