serializer: only inject properties to constructors of records #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
serializer-nerf-records
branch
from
7967007
to
3f949af
Compare
People were relying on the serializer *not* calling the constructor even when it contained what seemed to be properties. So we need to restrict the "record" behavior to records and to classes with explicitly marked JsonConstructor
exyi
force-pushed
the
serializer-nerf-records
branch
from
3f949af
to
71e7527
Compare
acizmarik
approved these changes
Dec 7, 2022
…dotvvm into serializer-nerf-records
tomasherceg
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People were relying on the serializer not calling the constructor even when it contained what seemed to be properties. So we need to restrict the "record" behavior to records and to classes with explicitly marked JsonConstructor