Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch custom primitive types to a marker interface #1682

Merged

Conversation

exyi
Copy link
Member

@exyi exyi commented Aug 1, 2023

This allows for efficient checks if a value is primitive without the need for cache hashtable containing all types we encounter

This allows for efficient checks if a value is primitive
without the need for cache hashtable containing all types we encounter
@@ -3,6 +3,7 @@
namespace DotVVM.Framework.ViewModel;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the class completely

}

private static CustomPrimitiveTypeRegistration? TryDiscoverCustomPrimitiveType(Type type)
private static CustomPrimitiveTypeRegistration TryDiscoverCustomPrimitiveType(Type type)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Try from the name since the method can crash

@exyi exyi merged commit 5754127 into feature/custom-primitive-types Aug 2, 2023
14 checks passed
@exyi exyi deleted the feature/custom-primitive-types-interface branch August 2, 2023 17:31
@exyi exyi added this to the Version 4.2 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants