Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added route groups #363

Merged
merged 1 commit into from Jun 6, 2017
Merged

Added route groups #363

merged 1 commit into from Jun 6, 2017

Conversation

Rumbeer
Copy link
Contributor

@Rumbeer Rumbeer commented Jun 3, 2017

Route groups can be added to a RouteTable, described in #224. Group has its prefixes for route name, url and virtual path. The group can be retrieved and works as a RouteTable.

Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contibution. Both the API and code looks good

@exyi exyi added this to the Version 1.2 milestone Jun 3, 2017
@exyi
Copy link
Member

exyi commented Jun 3, 2017

Could you just add you email address (433545@mail.muni.cz) to github, so we can see, that the commit was made by you? The settings it at https://github.com/settings/emails

@Rumbeer
Copy link
Contributor Author

Rumbeer commented Jun 3, 2017

Thank you for the reply, the email should be added now.

@exyi exyi merged commit 79c95ce into riganti:master Jun 6, 2017
@Rumbeer Rumbeer deleted the route-groups branch July 30, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants