-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: FormControls.Enabled #433
Conversation
This applies for following controls or others that derive from the same base classes: Button (ButtonBase) CheckBox (CheckableControlBase) ComboBox (SelectorBase) LinkButton (ButtonBase) ListBox (SelectorBase) RadioButton (CheckableControlBase) TextBox
Still needs a test for linkbuttons which do not currently work.
|
||
namespace DotVVM.Framework.Binding | ||
{ | ||
public class CustomDefaultProperty : DotvvmProperty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I see this name I can't imagine what is it good for. Is DotvvmPropertyWithFallback
better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't find either of those names very good and can't think of a better alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Will try to find a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about DefaultToPropertyDotvvmProperty
or PropertyDefaultDotvvmProperty
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or DelegatedDotvvmProperty
? Because it delegates call to another property when not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked @exyi and @tomasherceg and it's going to be DotvvmPropertyWithFallback
.
All controls in Business Pack will support |
FormControls.Enabled
proposed in #296
Adds a FormControls.Enabled property to all HTML elements which disables controls inside that are not explicitly enabled.
Controls affected
DotVVM
Bootstrap (not yet implemented)
Business pack (not yet implemented)
ListView (Business pack) does not have an Enabled property
DateTimePicker (Bootstrap) does not have an Enabled property
DropDownButton (Bootstrap) does not have an Enabled property
Example