Return 400 Bad request when csrf token is invalid #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
You are right, this should cause a "bad request" response. Maybe it would be even nicer to show some more info than just "invalid token". What about a simple page that would explain that it's probably caused by new keys on the server (for devs/admins) and that it's not a big deal and you can just clear cookies (with a button to do that, for users of the broken apps)
|
@exyi I've created separate issue for the html page. I'm merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4xx status code should be returned when CSRF token is invalid.
Currently we are returning 500 internal error.
I chose status code 400 as ASP.NET team https://github.com/aspnet/Antiforgery