Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RouteLink placed inside an element with Events.Click attribute #630

Merged
merged 3 commits into from
Feb 13, 2019

Conversation

adamjez
Copy link
Contributor

@adamjez adamjez commented Jul 24, 2018

This PR fixes RouteLink placed inside an element with Events.Click attribute. Currently, the RouteLink redirection is canceled and command is invoked.

Example:

<dot:GridView DataSource="{value: ...}">
        <RowDecorators>
            <dot:Decorator Events.Click="{command: ...}" />
        </RowDecorators>
        <Columns>
            <dot:GridViewTemplateColumn>
                <dot:RouteLink Text="Test Click Propagation" RouteName="Default"/>
            </dot:GridViewTemplateColumn>
        </Columns>
</dot:GridView>

What do you think about letting people control when the `event.stopPropagation()' is rendered and when not.

@adamjez adamjez requested a review from exyi July 24, 2018 13:35
@exyi
Copy link
Member

exyi commented Jul 24, 2018

I'm afraid this is basically a feature that was added by the event.stopPropagation() :(

@exyi
Copy link
Member

exyi commented Oct 10, 2018

I don't really like this solution as it will only work for RouteLinks and not other clickable components (inputs, normal links, ...). I'm afraid that the only correct solution is not to use Events.Click on a container that contains other clickable stuff.

@exyi exyi merged commit f14eb72 into master Feb 13, 2019
@exyi
Copy link
Member

exyi commented Feb 13, 2019

Although I don't really like this unsystematic solution it's still better than nothing... @adamjez Thank you.

@quigamdev quigamdev deleted the fix/routelink-with-rowdecorator branch September 18, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants