Easier creation of LoadFromQueryableAsync extension method #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to wait until .NET Core 3.0 is released to be able to make
LoadFromQueryableAsync
method (as explained in #670) sinceToListAsync
andCountAsync
are declared in EF Core assemblies and we didn't want DotVVM to depend on that.However, to allow users making their own implementation of
LoadFromQueryableAsync
as an extension method, I have changed several methods onGridViewDataSet
to be public.Making an extension method for
LoadFromQueryableAsync
can now be done like this:This also fixed one inconsistency we had on
GridViewDataSet
- allApply*ToQueryable
except forApplySortingToQueryable
were protected whileApplySortingToQueryable
was already public. Now they are all public.