Require a culture-specific globalize resource to accompany globalize when required by the compiler #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafour
requested review from
quigamdev and
tomasherceg
and removed request for
quigamdev
|
No more cleanup PRs today. Please revert that diff noise so I can do the code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694.
When
ToStringis called on a number in a binding, the compiler adds a property to remember to require the "globalize" resource. It didn't, however, require the current-culture-specific globalize to accompany it, which lead to problems like #694 (the FeatureSamples_Localization_Globalize sample).This PR attempts to fix this problem by adding a new control called
GlobalizeResourcewhose sole purpose is to callResourceManager.AddCurrentCultureGlobalizationResource, and a new binding property with a visitor that adds this control to the resolved tree when required just like before.