Fix a SetValue exception when in multilevel mark-up control #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
requested changes
Aug 1, 2019
|
Merging as, since CI doesn't seem to work properly right now, I ran the tests locally and they passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another bug reported by @JaskaRoman.
The problem is IMHO best described through the sample in this PR:
Let's have a
ComboBoxinside a markup control -InnerWrapper- that is wrapped in another markup control -OuterWrapper. The selected value of theComboBoxis bound using a value binding and two control bindings. If you try to set theSelectedValueofInnerWrapperusingSetValueyou get an exception because DotVVM doesn't currently allow bindings to propagate values in these cases.That's what this PR is trying to fix by changing the resolver of
BindingUpdateDelegate.