Static commands now reject the result promise #740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static commands return a promise that was however never rejected (and thus completed) when an error occurs. This PR fixes the behavior, puts the reject function into every asynchronous invocation present in the static command.
It was needed to slightly change the signature of the
dotvvm.staticCommandPostback
function as it must signal the error with only one argument.cc @Mylan719, this should fix your issue