Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null propagation now passes nulls into methods instead of skipping execution #817

Merged
merged 8 commits into from Feb 19, 2021

Conversation

exyi
Copy link
Member

@exyi exyi commented Mar 30, 2020

resolves #808

Null propagation used to skip method if at least one of the arguments was null, but this is quite strange, so let's switch to allowing the nulls there. If the type is a value type, an exception is thrown.

@exyi exyi changed the base branch from master to master-v3 March 30, 2020 16:53
@tomasherceg tomasherceg changed the base branch from master-v3 to v3-master August 7, 2020 11:46
@exyi exyi changed the base branch from v3-master to main November 4, 2020 20:46
@tomasherceg tomasherceg added this to the Version 3.0 Nice to have milestone Nov 7, 2020
Copy link
Contributor

@quigamdev quigamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found anything that would be preventing this PR from merging. Yesterday I found an issue with an indexer which is already fixed. So I think this PR is ready to go.

@quigamdev quigamdev merged commit 1bac555 into main Feb 19, 2021
@quigamdev quigamdev deleted the null-propagation-args branch February 26, 2021 17:46
@tomasherceg tomasherceg modified the milestones: After 3.0, Version 3.0 Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants