Recursive resolving of generic arguments types in registration of methods in javascript translation #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
requested changes
Oct 24, 2020
There was a problem hiding this comment.
Please see the comments in code and also please add unit tests for the behavior you have implemented - I don't see a reason to rely on UI tests for this. You can either add them as BindingCompilationTests or JavascriptCompilationTests (first option should be more stable, second also covers the translation to JS).
…ethod resolution.
exyi
reviewed
Nov 9, 2020
| return method; | ||
| var methods = FindValidMethodOveloads(type.GetAllMembers(flags).OfType<MethodInfo>().Where(m => m.Name == name), typeArguments, arguments, namedArgs).ToList(); | ||
|
|
||
| if (methods.Count == 1) return methods.FirstOrDefault(); |
There was a problem hiding this comment.
Nitpick: This special case is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites resolving of generic arguments in ExpressionHelper.
Example 1:
This registration is already allowed - this is how it was implemented so far.
Example 2:
This registration is not allowed in the current implementation. This PR makes it possible.