Implement support of @js directive #915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call module commands.
…or use in controls.
…using the same module. Test sample with symulated markup control.
…ort for named comand registration from the view.
It renders an inline script that imports the module and register it into dotvvm. When in a page, it is added into the serialized JSON. When in a control, it renders a binding handler with the specified module
… directive testing.
…JS directives feature.
|
This PR also solves #899. |
The bug is that DotvvmMarkupControl has the context of the parent view, only it's content should get the "inner context". Previous change that changed inheritance of ResolvedTreeRoot to ResolvedControl broke how it was working before
we use the control unique id. The id also has to be used in any commands invoking the module jsCommands. We can however reuse the infra for standard commands that also require control ID. Only issue could be when a command would migrate from one markup control to another, but that's considered unlikely given we add support for invoking _control.Command from staticCommands
|
Succeeded by #935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It renders an inline script that imports the module and register it into dotvvm.
When in a page, it is added into the serialized JSON.
When in a control, it renders a binding handler with the specified module