New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for basic type inference within lambda functions #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed implementation
I added a test that showcases this feature works with methods introduced by #965. It should work nicely together with method calls, but also with extension method calls. |
exyi
approved these changes
May 12, 2021
src/DotVVM.Framework/Compilation/Inference/Results/ITypeInferenceResult.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stanislav Lukeš <exyi@outlook.cz>
tomasherceg
approved these changes
May 14, 2021
src/DotVVM.Framework/Compilation/Binding/ExpressionBuildingVisitor.cs
Outdated
Show resolved
Hide resolved
src/DotVVM.Framework/Compilation/Inference/Inferers/LambdaInferer.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for type inference within lambda functions.
Overview
We try to infer information about lambdas based on provided arguments and context in which the lambda is being used. Current biggest limitation is that we do not take into account lambda bodies. Still, in most cases, this simpler approach should work and infer correct type information. Following situations are covered by the type inferer:
SortChanged
on gridsAction<..>
, return value gets discarded and as such the compilation result can be treated as anAction<..>
Breaking change
Interface
IBindingExpressionBuilder
was altered by adding an optional parameter to its Parse method. Regardless, I do not think that this change could actually break someone