Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for extension methods #946

Merged
merged 11 commits into from Apr 9, 2021

Conversation

acizmarik
Copy link
Member

This PR improves experience when working with extension methods. The main changes are:

  • Directive @import should be used to define which namespaces should be searched for extension methods
  • Namespace System.Linq was added to default imports
  • Introducing ExtensionMethodsCache to cache found extension methods for individual namespaces

Method overload resolving was not changed

@quigamdev quigamdev requested review from quigamdev and exyi and removed request for quigamdev February 23, 2021 17:55
@quigamdev quigamdev self-requested a review February 23, 2021 17:55
@tomasherceg tomasherceg added this to the Version 3.1 milestone Mar 27, 2021
Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :) Please, just change the cached type and it's perfect.

src/DotVVM.Framework/Compilation/ExtensionMethodsCache.cs Outdated Show resolved Hide resolved
src/DotVVM.Framework/Compilation/ExtensionMethodsCache.cs Outdated Show resolved Hide resolved
@tomasherceg tomasherceg merged commit 2922ad6 into main Apr 9, 2021
@tomasherceg tomasherceg deleted the feature/extension-methods-improvements branch April 9, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants