Improved error reporting for corrupted master page #976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes weird DotVVM error reported by @martindybal. If user makes a mistake while specifying viewmodel (by referencing a non-existing class) for their master page, they receive a somewhat confusing error message.
The problem:
dotvvm/src/DotVVM.Framework/Compilation/ControlTree/Resolved/ResolvedTreeBuilder.cs
Line 149 in 7dc7e9d
dotvvm/src/DotVVM.Framework/Compilation/ControlTree/Resolved/ResolvedTreeRoot.cs
Line 29 in 7dc7e9d
If we were to add those errors there, I am not sure whether it could break something. In the meantime, I created a simple fix that should not break anything and provides users with a more specific error message.