Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error reporting for corrupted master page #976

Merged
merged 1 commit into from Apr 9, 2021

Conversation

acizmarik
Copy link
Member

This PR fixes weird DotVVM error reported by @martindybal. If user makes a mistake while specifying viewmodel (by referencing a non-existing class) for their master page, they receive a somewhat confusing error message.

image

The problem:

If we were to add those errors there, I am not sure whether it could break something. In the meantime, I created a simple fix that should not break anything and provides users with a more specific error message.

Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@tomasherceg tomasherceg added this to the Version 3.1 milestone Mar 27, 2021
@tomasherceg tomasherceg merged commit fad57d9 into main Apr 9, 2021
@tomasherceg tomasherceg deleted the bugfix/better-error-corrupted-masterpage branch April 9, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants