Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When transcoding file(s) with multiple streams (for example multilanguage subtitles) NVEnc sets all as DEFAULT #33

Closed
jeryll7 opened this issue Feb 17, 2018 · 4 comments

Comments

@jeryll7
Copy link

jeryll7 commented Feb 17, 2018

NVEnc should copy DEFAULT attributes from source to destination, sure, this may look as triviality, but for example ffmpeg can copy DEFAULT stream attribute correctly.

This is easily reproducible, just use media file with multiple subtitle stream included, check with mediainfo for how the DEFAULT attribute is set, transcode file with NVEnc with --sub-copy option, then check result file with mediainfo - all subtitle streams will have DEFAULT attribute set.

@rigaya
Copy link
Owner

rigaya commented Feb 19, 2018

I have added code to copy attributes of streams (audio & subtitles) in NVEnc 3.29.

@jeryll7
Copy link
Author

jeryll7 commented Feb 19, 2018

OK, thanks, I can confirm that NVEnc 3.29 correctly copies audio and subtitles streams default attributes, but unfortunately now VIDEO stream DEFAULT attribute (if set) is not copied (also VIDEO stream LANGUAGE attribute is not copied - is missing in result file).
Should I close this and open a new issue?

@rigaya
Copy link
Owner

rigaya commented Feb 20, 2018

OK, NVEnc 3.30 will copy attribute of video when possible (for avhw/avsw reader).

@jeryll7
Copy link
Author

jeryll7 commented Feb 20, 2018

Ok, thanks, NVEnc 3.30 now copies stream(s) attributes correctly.

@jeryll7 jeryll7 closed this as completed Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants