-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a configuration file (e.g. for keybindings, etc.) #46
Comments
This could be an interesting one. Are there any bindings that don't currently work for you? |
I think the current bindings are very nice and appeal to the majority of users. But there are also users who might have other preferences (as you could see about the bindings for playback control #16). Having a config for keybindings would be a nice addition for users who are into customizing everything as much as they can. My suggestion would be that the default settings/bindings (which satisfy the most users) stay in the source code and the config which is being read can overwrite certain bindings. That way the config file doesn't contain all bindings but only the ones users want to change. Currently I would not merge the client settings into the config yet and get rid of the client.yml. I think it would be nice if you could set these in the config.yml but the client.yml should stay to make it less of a hassle for users who sync their dotfiles with other computers. This is stuff for a later PR anyways. I think I would rename What do you think? |
This will add a `config.yml` file along side the `client.yml` file which will allow the user to configure custom keybindings. Currently this commit only covers global keybindings and not per-screen keybindings but this could be added in the future. This commit also doesn't currently allow for overriding default navigation keys (hjkl etc.) but that could also be added later. Resolves: Rigellute#46
Create a config for easy customization of keybindings, program behaviour, etc. It could be located at
$HOME/.config/spotify-tui/config.yml.
The current client configurations could be moved into this configuration too.
E.g
The text was updated successfully, but these errors were encountered: