Fixed naive_program_generator qubit selection problem #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebook to match previous api change.
|
@karalekas these tests pass and seem to be deterministic locally--any idea they would fail? Does the seeding work differently non-locally? |
|
@kylegulshen Do you want to make this UT less random seed sensitive before we proceed? |
|
Ok I fixed it. Only one of the parts was sensitive. |
…benchmarking into quantum-volume-index-bug
joshcombes
approved these changes
Mar 26, 2019
karalekas
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if two consecutive indices in the provided qubits were not connected then the program generation would fail even if there were sufficiently many available qubits.