Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default conf on get qcs qpu #1333

Merged
merged 1 commit into from
May 13, 2021
Merged

Provide default conf on get qcs qpu #1333

merged 1 commit into from
May 13, 2021

Conversation

erichulburd
Copy link
Contributor

@erichulburd erichulburd commented May 5, 2021 •
edited

Description

Let's not force users to initialize their own configuration when calling get_qcs_quantum_processor.

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@erichulburd erichulburd requested a review from a team as a code owner May 5, 2021 21:53
@erichulburd erichulburd changed the base branch from master to rc May 5, 2021 21:53
@erichulburd erichulburd force-pushed the provide_default_conf_on_get_qcs_qpu branch from a1237e3 to 2b7d8f9 Compare May 5, 2021 21:59
ameyer-rigetti
ameyer-rigetti suggested changes May 6, 2021
View reviewed changes
pyquil/quantum_processor/qcs.py Outdated Show resolved Hide resolved
@erichulburd erichulburd force-pushed the provide_default_conf_on_get_qcs_qpu branch from 2b7d8f9 to 79ab4fc Compare May 12, 2021 23:04
@erichulburd erichulburd force-pushed the provide_default_conf_on_get_qcs_qpu branch from 79ab4fc to f05a719 Compare May 13, 2021 16:48
@erichulburd erichulburd merged commit 7d54936 into rc May 13, 2021
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.0.0-rc.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ameyer-rigetti ameyer-rigetti deleted the provide_default_conf_on_get_qcs_qpu branch July 12, 2021 18:58
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameyer-rigetti ameyer-rigetti ameyer-rigetti approved these changes

Assignees
No one assigned
Labels
released on @rc released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erichulburd @rigetti-githubbot @ameyer-rigetti