Feature: record structured output per shot, print json in transpile-to-quil #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
suggested changes
Apr 11, 2022
|
No change to MSRV. |
kalzoo
requested changes
Apr 13, 2022
There was a problem hiding this comment.
lgtm, the trait seems like a good way to solve this - although I wonder if a simple function (like you have commented out) would serve the same purposes with less complexity. That is, implementers of that trait only exist to then be formatted into a string, so maybe just a function that formats directly to string would do the job?
dbanty
reviewed
Apr 14, 2022
dbanty
reviewed
Apr 14, 2022
nilslice
force-pushed
the
sm/qir-record-output
branch
from
172737f
to
8b456f1
Compare
dbanty
approved these changes
Apr 14, 2022
kalzoo
reviewed
Apr 15, 2022
Co-authored-by: Kalan <22137047+kalzoo@users.noreply.github.com>
nilslice
force-pushed
the
sm/qir-record-output
branch
from
82d7339
to
444a798
Compare
kalzoo
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could use some help w/ best placement for
RecordedOutputand ideal visibility... it needs to bepub, and while it is used internally toqcs-sdk-qir, it is also used in an external to-be-published crate.