Allow msgpack (0.6 <= v < 2.0) #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalzoo
commented
Mar 23, 2023
| raw=False, | ||
| max_bin_len=max_bin_len, | ||
| max_str_len=max_str_len, | ||
| strict_map_key=False, |
There was a problem hiding this comment.
stylewarning
approved these changes
Mar 23, 2023
notmgsk
approved these changes
Mar 23, 2023
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jamesclark-Zapata for the original change. This is long overdue - support for
msgpack >= 1.0.The
strict_map_keykwarg was already supported as ofv0.6.2, its default value just changed atv1.0. So, I've left0.6.2supported and just bumped the upper bound so that this isn't a breaking change and won't trade one set of incompatibilities for another.rpcqis on the way out from most production use cases shortly so this should be plenty of headroom to get it to EOL.