Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to select answers in Trick Answer selection screen #44

Closed
amarax opened this issue Sep 29, 2020 · 4 comments
Closed

Not able to select answers in Trick Answer selection screen #44

amarax opened this issue Sep 29, 2020 · 4 comments
Assignees
Labels
bug Something isn't working mobile-app the mobile app

Comments

@amarax
Copy link
Contributor

amarax commented Sep 29, 2020

When viewing this screen, pressing on the grey dots doesn't select the answer.

Tested on iOS 13.7 iPhone X

IMG_CCF7CD4524BB-1

@amarax
Copy link
Contributor Author

amarax commented Sep 29, 2020

The correct answer was not yet entered in this case.

@maniramezan
Copy link
Collaborator

@amarax Yes, it was my impression that it is the case, if not, let me know, I can change the logic and fix it without any new binary releases.

@sincwu
Copy link
Collaborator

sincwu commented Sep 29, 2020

+1 to the suggestion from today's meeting to focus on the single-device scenario and update screens/details to reflect that. In this scenario, because there's only one device, that device is able to both 1) enter trick answers and 2) serve as a Facilitator who chooses the trick answers that are submitted (the ones that are randomly mixed in with the correct answer and shown to the rest of the class).

As shown in the Facilitator flow in Figma, please note that the Facilitator is able to select/unselect answers as soon as even 1 trick answer has been entered (this can happen before the correct answer has been guessed/revealed). This ability to be able to select/unselect answers as soon as even 1 trick answer has been entered applies to both the single- and multi-device scenarios. Great UX & dev collaboration -- thanks to both of you, Mani & Yong Lin!

maniramezan added a commit that referenced this issue Oct 6, 2020
Fixes bugs:
* [#Issue44](#44)
* [#33](#33)
@maniramezan maniramezan self-assigned this Oct 6, 2020
@maniramezan maniramezan added bug Something isn't working good first issue mobile-app the mobile app labels Oct 6, 2020
@maniramezan
Copy link
Collaborator

Implemented and pushed to appcenter as part of #39. This should be fixed in the latest app version and js bundle

ryanabooth added a commit that referenced this issue Nov 7, 2021
* add new dev/master branch strategy

* Updated Branching section

* updated XCode credentials; empty space changes to trigger Android rebuild

* update version information

* fix for issue 166312975

* fix for issue 165516916; missing back button on iOS in role selection screen

* update version string color/size

* New Game functionality does not seem to work

* new game button and issue number 7

* fix broken build and missing file from previous checkins

* merge project changes from dev and update version numbers

* create web app (#5)

* npm audit

* init

* wip

* add question form (#6)

* add router (#7)

* add new game dialogue and game form (#9)

* init game form

* missing useCallback dependencies

* fix add game bug

* move question form, add back button

* add new game dialogue

* add description and change button text

* fix bug

* add delete solution step button (#12)

* move add question button (#13)

* Update README.md

* Update README.md

* [API] hook up list games (#15)

* [API] add create and save game requests (#16)

* [API] create game added

* [API] save game added

* Update ReactNative to 0.62 and update the UI for first screen

Updated the RN to 0.62 and many other outdated libraries in addition to fixing iOS and Android projects to reflect these changes. This update breaks the mobile app as Navigation 5.x is not backward compatible and the app requires refactoring to anticipate these changes.

* Move all app related files to mobileapp

This change is for cleaning up the root folder and making it easier to navigate between web and mobile applications. Also, this helps for anybody who views that hierarchy on the repo, finds out that there are both web and mobile apps in this repo.

* [API] handle various loading/refetch state errors (#21)

* Update README.md

Added Mission and Vision
Updated Project Description

* Update README.md

* Update README.md

* Create README.md

* Update README.md

1. Added sentence in the Mission section to provide more info re: what makes RightOn different from other math apps
2. Added Our Values section

* Update README.md

* Update README.md

Minor updates to Communication Channels section, including mention of Slack

* Update README.md

* add screenshots for docs

* Update README.md

* sort games by updated at and open the newest on create (#24)

* [UI] move title and description to game edit form (#23)

* [UI] move title and description to game edit form

* add game id

* display hover state and selected game

* sort games by updated at and open the newest on create (#24)

* [UI] move title and description to game edit form

* add game id

* display hover state and selected game

* fix bugs

Co-authored-by: Ryan Booth <ryan.booth@airbnb.com>

* Add search to games column (#25)

Co-authored-by: Ryan Booth <ryan.booth@airbnb.com>

* quickfix: game index error with sorting

* Update README.md

* UI changes for Games page and Question cards (#26)

* games UI notes

* question card visual changes

* add actions, fix save game redirect

* text formatting from Jordan

* Add CCSS field (#27)

* Game card UI changes (#28)

* Update README.md

* Integrate custom fonts used in the mockups

* Add Teacher screen explore page mock pages

* Add appsync api call for loading games

* Add game intro screen and loading before showing intro

* Add encryption compliance

* Change font for buttons

* Add GamePreview, spinner, trick answers component, overview of question component

* Hook up Trick answers and hints UIs

* Update RN to 0.63 with other outdated packages

* Add answering question and adopt new changes for guessing the right answer

* add game actions (delete / duplicate) (#30)

* add CCSS to game view

* change Nav title

* change game actions to a dropdown menu

* add delete game

* add duplicate game

* display CCSS with periods

* add duplicate method

* Remove Pods folder

This is producing too much noise into RN version udpates and any other node module updates. At the end, we’re not heavility using Pods and also, either way, others need to run `npm install` when setting up the project. So they can also just run pod install as part of initialization.

* Remove dSYM file

This file is not needed anymore since the TF that was hosting the last build got expired.

* Separate gitignore for mobile apps

* Update readme to match latest changes

* Update README.md

* Many bug fixes and RN 0.63.1 update

* Issue #35 [Entering Trick Answers] Remove the spinning timer component from the Trick Answers card (and keep it for just the Hints card)
* Issue #34 [Entering Trick Answers] After an incorrect/trick answer has been entered, the "What do you think the correct answer is?" field should be cleared
* Issue #33 Trick answers, once added, should be read-only and have a larger clickable area
* Issue #31 "Don't Get Tricked!" screens are displaying incorrect instructions

* Update to RN 0.63.2 and all other outdated packages

* Update README.md

* empty search results bug fixed

* [web] add game grid, game sorting, loading status and fix height of game cards (#40)

* Add game grid and game sorting

* add loading status and fix search bug

* fixed height game cards

* Update trick answers flow

* Trick answer latest changes
* Continue with remaining screens. still WIP

* Update trick answer with latest changes.

Fixes bugs:
* [#Issue44](#44)
* [#33](#33)

* Add facilitator role

* Update dependencies

* Fix height issue for trick answer text field on iOS

* Fix the timer that was reduced for testing

* select new game after duplication (#45)

* Add codepush syncing policy

* Updating to RN 0.63.3 and also all otehr dependencies to the latest

* Increment build number

* Update gradle build tools

* Add result screen first page

* Update dependencies

* Fix text messages show to facilitator and non-facilitator users.

* [Alerts] Add alert bar and context (#53)

* Update dependencies

* Fix duplicate component name due to copy-paste issue

* Fix the copy for trick answer

* Run pod install

* Default voting default page to answers screen

* Make answer review page not editable

* And popular answered page screen

* fix navigation to game on action click (#55)

* change duplicate to clone (#56)

* Update dependencies

* [web] change copy of to clone of

* [web] select game when edit action clicked (#67)

* Fix the delay in re-rendering FlatList when data changes

* Fix the scrolling issue

* Increase timer for showing message to user

* Rollback appcenter upgrade

AppCenter 4.0.0 has removed App Push from it’s binary and we need to go through proper migration to support this upgrade.

* Increment the build for iOS

* Something gradle wanted to do 🤷‍♂️

* connected data teacher games list

* Update dependencies

* Add final result review screen

* Update pods

* Fix percentage bar to be dynamic

* Add Leadership page initial page

* Update dependencies

* Add question to leadership header and sort answers based on percentage

Fixes #80

* create Further Details Page teacher side (#86)

* create Further Details Page teacher side

* Update code for detailscreen page (code readability)

* add schema of the App Sync api

* [GraphQL] create docs for updating schema file

* ERD and entity analysis for game session entities

The initial work to implement and model dynamodb scheme

* [Mobile] 3rd party libraries updated

* Remove unnecessary AWS config and Amplify references

* Remove unnecessary aws exports file and its refereneces

* Upgrade pod dependencies to make build compatible with latest XCode

* Fix for android bug that shows up on initial screen

* Update the new dependecy for RNReanimated

* Integrating the animation from POC with the app

* Refactor navigation to remove bottom tab

* Rename variables

* Rename variables properly

* Fix existing styling on detail screen page

* Create footer view

* Wire up navigation for overseeing games

* Add package for accordion

* Create higher level components

* Components to support the teacher screens

* Fixing styling and naming issues from previous commit

* Fixing styling and adding phase 1 screen

* Add new question screen and change styling according to latest figma

* Update Android and iOS config for Accordion library

* Add results screen and reformat code

* Remove ; from the code

* Make changes according to PR review

* Update ERD

* Update image

* Make all requested changes part 2

* [Web] [GraphQL] Add AppSync resources to source control (#129)

This includes AppSync schema, resolvers, and functions which are needed to be included in the source control in order to track the changes and keep a backup version from it.

* [Webapp] initializing new api (#131)

* [Webapp] initializing new api

* update vulnerable package

* rendering with no errors

* package updates

Co-authored-by: Edward Tan <guofoo@gmail.com>
Co-authored-by: Amanpreet <amanbhandal977@gmail.com>
Co-authored-by: sincwu <sincwu@users.noreply.github.com>
Co-authored-by: Mani Ramezan <mani.ramezan@gmail.com>
Co-authored-by: Mani Ramezan <maniramezan@users.noreply.github.com>
Co-authored-by: Ryan Booth <ryan.booth@airbnb.com>
Co-authored-by: Eric Nguyen <53154237+EricNguyen-B@users.noreply.github.com>
Co-authored-by: Ankit Trehan <ankittrehan2000@gmail.com>
Co-authored-by: ankittrehan2000 <47463734+ankittrehan2000@users.noreply.github.com>
@ryanabooth ryanabooth added this to the Mobile MVP Checklist milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mobile-app the mobile app
Projects
None yet
Development

No branches or pull requests

4 participants