St 1 ephemeral previously formatted #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 2, 2015 23:28
| default['ephemeral_lvm']['filesystem'] = "ext4" | ||
| # RHEL 7 and CentOS 7 uses XFS as their default file system. | ||
| default['ephemeral_lvm']['filesystem'] = | ||
| node['platform'] =~ /redhat|centos/ && node['platform_version'] =~ /^7\./ ? 'xfs' : 'ext4' |
There was a problem hiding this comment.
Let's use value_for_platform_family for this, I think you will be able to just use 'rhel' as the family name.
There was a problem hiding this comment.
kitchen testing shows using value_for_platform_family works fine. However, testing in RS returns the following error: Option filesystem must be a kind of String! You passed {["7.0", "7.1"]=>"xfs", "default"=>"ext4"}. To continue moving forward, I will use 'node["platform_family"] and node['platform_version'].
added 7 commits
April 7, 2015 15:08
…d based on OS. Remove setting of ephemeral_lvm:filesystem to use default values.
…eady exists which determines that lvm already is setup so need to run wipefs.
…in attributes/default.rb.
…ult due to RS not interpreting value_for_platform_family correctly.
…e/bats/verify_ephemeral.bats.
douglaswth
added a commit
that referenced
this pull request
Apr 8, 2015
…ously_formatted St 1 ephemeral previously formatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.