Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Documenter dep. #10

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

MichaelHatherly
Copy link
Contributor

Vendor the submodules function from there instead of import the package. Fixes #7.

The function hasn't really changed much in the years since I wrote so it's probably better to just vendor it here rather than pulling in the entire dep.

MichaelHatherly and others added 2 commits May 11, 2022 19:19
Vendor the `submodules` function from there instead of import the
package. Fixes rikhuijzer#7.
@rikhuijzer
Copy link
Owner

Thanks! Much appreciated! Cool to learn that you're also the original author of that small piece of code years ago

@rikhuijzer rikhuijzer enabled auto-merge (squash) May 11, 2022 18:28
@MichaelHatherly
Copy link
Contributor Author

Cool to learn that you're also the original author of that small piece of code years ago

It makes me feel old way older than I should feel 🤣

@rikhuijzer
Copy link
Owner

It makes me feel old way older than I should feel 🤣

Haha. Nah. Early adopter is what I concluded ;p

@rikhuijzer rikhuijzer disabled auto-merge May 11, 2022 18:40
@rikhuijzer rikhuijzer merged commit 507b7d6 into rikhuijzer:main May 11, 2022
@MichaelHatherly MichaelHatherly deleted the mh/no-documenter branch May 11, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid the Documenter dependency?
2 participants