Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rule removal depend on gap in output #22

Merged
merged 23 commits into from
Jun 27, 2023
Merged

Make rule removal depend on gap in output #22

merged 23 commits into from
Jun 27, 2023

Commits on Jun 22, 2023

  1. Fix rule outputs in tests

    @rikhuijzer
    rikhuijzer committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3c551af View commit details
    Browse the repository at this point in the history

  2. Document gap

    @rikhuijzer
    rikhuijzer committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7150fa3 View commit details
    Browse the repository at this point in the history

  3. Add rref

    @rikhuijzer
    rikhuijzer committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    cbff84f View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @rikhuijzer
    rikhuijzer committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    97f4f54 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Add tmp.jl

    @rikhuijzer
    rikhuijzer committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    43b63cb View commit details
    Browse the repository at this point in the history

  2. Implement implications

    @rikhuijzer
    rikhuijzer committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    c626037 View commit details
    Browse the repository at this point in the history

  3. Create the space

    @rikhuijzer
    rikhuijzer committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    027dcbd View commit details
    Browse the repository at this point in the history

  4. Work through example

    @rikhuijzer
    rikhuijzer committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6bdbd04 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Write a very clear docstring for _feature_space

    @rikhuijzer
    rikhuijzer committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    52be1f9 View commit details
    Browse the repository at this point in the history

  2. Improved accuracy slightly

    @rikhuijzer
    rikhuijzer committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    67e3ec6 View commit details
    Browse the repository at this point in the history

  3. Slighty better perf again

    @rikhuijzer
    rikhuijzer committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    ea1def0 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Improve accuracy further

    @rikhuijzer
    rikhuijzer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    65907ae View commit details
    Browse the repository at this point in the history

  2. Getting closer (hopefully)

    @rikhuijzer
    rikhuijzer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e78116a View commit details
    Browse the repository at this point in the history

  3. Fix a bug in _feature_space

    @rikhuijzer
    rikhuijzer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    37c8bfc View commit details
    Browse the repository at this point in the history

  4. Make shuffle work for _filter_linearly_dependent

    @rikhuijzer
    rikhuijzer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    35ffda9 View commit details
    Browse the repository at this point in the history

  5. Something still wrong

    @rikhuijzer
    rikhuijzer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    0d162ee View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Cleanup

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e4c6099 View commit details
    Browse the repository at this point in the history

  2. Simplify _filter_linearly_dependent

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d50abe5 View commit details
    Browse the repository at this point in the history

  3. Localized another bug

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    eb74b60 View commit details
    Browse the repository at this point in the history

  4. Fix a bug in the rank calculation

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    20624a5 View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    83f120a View commit details
    Browse the repository at this point in the history

  6. Also test _process_rules

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1d770e7 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary rule

    @rikhuijzer
    rikhuijzer committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    398b974 View commit details
    Browse the repository at this point in the history