Mailers #14
Mailers #14
Conversation
spec/spec_helper.rb
Outdated
| name: 'Purple People Eater', | ||
| email: 'purplepeopleeater@gmail.com' | ||
| } | ||
| }) |
There was a problem hiding this comment.
Indent the right brace the same as the first position after the preceding left parenthesis.
spec/spec_helper.rb
Outdated
| info: { | ||
| name: 'Purple People Eater', | ||
| email: 'purplepeopleeater@gmail.com' | ||
| } |
There was a problem hiding this comment.
Indent the right brace the same as the start of the line where the left brace is.
spec/spec_helper.rb
Outdated
| get '/auth/google_oauth2?session_type=provider/callback' | ||
| def sign_in_provider(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ | ||
| provider: 'google_oauth2', |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
spec/spec_helper.rb
Outdated
| request.env['omniauth.env'] = OmniAuth.config.mock_auth[:google_oauth2] | ||
| get '/auth/google_oauth2?session_type=provider/callback' | ||
| def sign_in_provider(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ |
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
| OmniAuth.config.mock_auth[:google_oauth2] | ||
| request.env["omniauth.auth"] = authHash | ||
| request.env["omniauth.params"] = { "session_type" => "user" } | ||
| }) |
There was a problem hiding this comment.
Indent the right brace the same as the first position after the preceding left parenthesis.
spec/spec_helper.rb
Outdated
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ | ||
|
|
||
| def sign_in_user(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ |
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
| scenario "it destroys the session" do | ||
| visit root_path | ||
| click_link "Sign Out" | ||
| expect{session}.to raise_error(NameError) |
There was a problem hiding this comment.
Space missing to the left of {.
Space missing inside {.
Space missing inside }.
| visit root_path | ||
| click_link "Sign Out" | ||
| expect(response).to have_http_status(:success) | ||
| expect{session}.to raise_error(NameError) |
There was a problem hiding this comment.
Space missing to the left of {.
Space missing inside {.
Space missing inside }.
spec/factories/users.rb
Outdated
| @@ -2,6 +2,6 @@ | |||
| factory :user do | |||
| sequence(:name) { |n| "User #{n}" } | |||
| sequence(:email) { |n| "testemail#{n}@example.com" } | |||
| sequence(:uid) { |n| } | |||
| sequence(:uid) { |n| "#{n}"} | |||
There was a problem hiding this comment.
Prefer to_s over string interpolation.
Space missing inside }.
| uid: '12345', | ||
| def sign_in_provider(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ | ||
| provider: 'google_oauth2', |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
| OmniAuth.config.add_mock(:google_oauth2, { | ||
| uid: '12345', | ||
| def sign_in_provider(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ |
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
| } | ||
| def sign_in_user(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ | ||
| provider: 'google_oauth2', |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
| "email" => 'purplepeopleeater@gmail.com' | ||
| } | ||
| def sign_in_user(uid = '123545') | ||
| OmniAuth.config.mock_auth[:google_oauth2] = OmniAuth::AuthHash.new({ |
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
No description provided.