cleanup code + fix typo #22
Conversation
we do not need to close file descriptors before exit because exit does that for us
src/pak_creator.c
Outdated
|
|
||
| if (dirp == NULL) | ||
| if (n == -1) | ||
| { | ||
| printf("%s: Directory does not exist or is not accessable\n", dirName); |
|
btw. man page says scandir() is available since 4.3BSD, POSIX.1-2008 |
|
I'm not sure what this does? Is there a bug in the packing code? |
|
It's ok, POSIX is the lowest common divisor. But Windows... Sent from my Samsung SM-A520F using FastHub |
|
@riksweeney not a bug, right now paks do not differ of the order of their files anymore. Sent from my Samsung SM-A520F using FastHub |
|
OK. I just tried the updated code and the Windows version now fails to compile. |
|
@riksweeney https://groups.google.com/forum/m/#!topic/comp.os.ms-windows.programmer.win32/SO0pdXmRFHY Sent from my Samsung SM-A520F using FastHub |
|
I guess the alternative approach would be to leave this code as is and make it build+install+work with NO_PAK=1 |
|
That's a better idea. |
|
re-using this PR for the code cleanup and typo fix and #23 for the makefile improvement |
one trivial cleanup commit
and one typo fix
See commit messages for details.