Skip to content

Commit

Permalink
Fix #150 Problem with setQuery in socket io version 3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
jumperchen committed Feb 22, 2021
1 parent 42d0479 commit 7d3d213
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 2.0.0-beta.3

**Bug fix:**

* [#150](https://github.com/rikulo/socket.io-client-dart/issues/150) Problem with setQuery in socket io version 3.0

## 2.0.0-beta.2

**Bug fix:**
Expand Down
8 changes: 4 additions & 4 deletions lib/src/socket.dart
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@ class Socket extends EventEmitter {

// write connect packet if necessary
// if ('/' != nsp) {
if (query?.isNotEmpty == true) {
packet({'type': CONNECT, 'query': query});
} else {
// if (query?.isNotEmpty == true) {
// packet({'type': CONNECT, 'query': query});
// } else {
packet({'type': CONNECT});
}
// }
// }
}

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: socket_io_client
description: Dartlang port of socket.io-client for web, flutter, dartvm to use
version: 2.0.0-beta.2
version: 2.0.0-beta.3
homepage: https://www.zkoss.org
repository: https://github.com/rikulo/socket.io-client-dart
issue_tracker: https://github.com/rikulo/socket.io-client-dart/issues
Expand Down

0 comments on commit 7d3d213

Please sign in to comment.