Fixed #343 Empty query map in OptionsBuilder throws RangeError

rikulo · Feb 17, 2024 · 99e93dd · 99e93dd
1 parent e2e1a0e
commit 99e93dd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 * [#55](https://github.com/rikulo/socket.io-client-dart/issues/55) how to custom parser
 * [#322](https://github.com/rikulo/socket.io-client-dart/pull/322) added emitWithAckAsync
 * [#334](https://github.com/rikulo/socket.io-client-dart/pull/334) Socket.on... returns disposer function
+* [#343](https://github.com/rikulo/socket.io-client-dart/issues/343) Empty query map in OptionsBuilder throws RangeError
 * [#353](https://github.com/rikulo/socket.io-client-dart/issues/353) Add timeout on emit and emitWithAck
 
 **Bug fix:**

diff --git a/lib/src/engine/parseqs.dart b/lib/src/engine/parseqs.dart
@@ -28,6 +28,9 @@ String encode(Map obj) {
 /// @api private
 ///
 Map decode(qs) {
+  if (qs.isEmpty) {
+    return <dynamic, dynamic>{};
+  }
   var qry = <dynamic, dynamic>{};
   var pairs = qs.split('&');
   for (var i = 0, l = pairs.length; i < l; i++) {

diff --git a/lib/src/socket.dart b/lib/src/socket.dart
@@ -536,7 +536,7 @@ class Socket extends EventEmitter {
 
     for (var packet in sendBuffer) {
       notifyOutgoingListeners(packet);
-      packet(packet);
+      this.packet(packet);
     }
     sendBuffer = [];
   }