Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we combine emitWithBinary to emit? #106

Closed
zeroprofit opened this issue Jul 12, 2020 · 3 comments
Closed

Can we combine emitWithBinary to emit? #106

zeroprofit opened this issue Jul 12, 2020 · 3 comments
Labels
enhancement
Milestone
Socket.io V3

Comments

@zeroprofit
Copy link

I suggest emit should include "binary" detection so that exception method like "emitWithBinary" is not needed and it is API compatible to Javascript version.
@jumperchen
Copy link
Member

Welcome to contribute :)

@jumperchen jumperchen added this to the Socket.io V3 milestone Dec 21, 2020
jumperchen added a commit that referenced this issue Dec 21, 2020
@jumperchen
1. Resolved #130 Cannot connect to socket.io V3
1ee0cad 
2. Resolve #106 Can we combine emitWithBinary to emit?
@jumperchen
Copy link
Member

Resolved in 2.0-beta branch.

jumperchen added a commit that referenced this issue Mar 10, 2021
@jumperchen
Merge branch '2.0-beta' into 2.0-beta-nullsafety
b375b6e 
* 2.0-beta:
  fine tune document for 2.0.0-beta.0
  1. Resolved #130 Cannot connect to socket.io V3 2. Resolve #106 Can we combine emitWithBinary to emit?
@lsegal
Copy link

lsegal commented Oct 5, 2023

Was this ever tested or used? It looks like the change in 1ee0cad#diff-0194bfca3ac4fbbe2cdd7719d6f11c5753a72a36cd553b775de849882915b5a5R152 has basically forced all data to be send as non-binary, thereby entirely removing binary support altogether.

Am I missing something here? We are running into this issue after upgrading to 2.x after all this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Socket.io V3
Development

No branches or pull requests
3 participants
@lsegal @jumperchen @zeroprofit