Allow sending an ack with multiple data items (making it consistent with emit) #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the 'ack' function to use the same logic as 'emitWithAck' when populating the 'data' list. This allows to send an ack with more than one data items.
|
Thanks for the contribution. |
jumperchen
added a commit
that referenced
this pull request
Nov 19, 2021
jumperchen
added a commit
that referenced
this pull request
Jul 13, 2022
DanielWHoward
pushed a commit
to DanielWHoward/socket_io_client_flutter
that referenced
this pull request
Dec 2, 2022
DanielWHoward
pushed a commit
to xibbit/socket_io_client_flutter
that referenced
this pull request
Dec 2, 2022
|
Please tell me how to close this print in the terminal of visual code: flutter: [2023-03-21 16:03:39.513626 | socket_io_client:engine.Socket | FINE] socket receive: type "message", data "2["idx",{"a":"u","d":[{"TD":"21/03/2023","NOF":"5","t":1679389419635,"MC":"HNX","SM":"515761","IT":"11:29:14"}]}]" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR changes the
ackfunction to use the same logic asemitwhen populating thedatalist. This allows to send an ack with more than one data items.I find the ability to return multiple items quite useful. Moreover, having the same logic in
emitandackis what the user would expect, and makes the code consistent.