Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed RangeError #8

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fixed RangeError #8

merged 1 commit into from
Oct 25, 2022

Conversation

claudius-kienle
Copy link
Contributor

The parser first accesses the next character before checking if is not at the end of the string causing a RangeError.
This exception occured only, if I try to connect socket_io_common v2.* to a socket_io Server v2.*, which is not supported.
Changing the order yield then yields the correct warning that the two versions are incompatible.

@jumperchen jumperchen merged commit 90fdac8 into rikulo:master Oct 25, 2022
@jumperchen
Copy link
Member

thanks for the contribution.

jumperchen added a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants