Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use macro instead of function for HRESULT_FROM_WIN32 #130

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Use macro instead of function for HRESULT_FROM_WIN32 #130

merged 1 commit into from
Mar 28, 2023

Conversation

michaelKle
Copy link
Contributor

Description

Use the double underscore macro instead of the non constexpr function.

Motivation and Context

It fixes #129

How Has This Been Tested?

Tested compilation with MSVC 2017 and 2019

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@rikyoz rikyoz self-assigned this Mar 28, 2023
@rikyoz rikyoz merged commit cd68986 into rikyoz:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rikyoz rikyoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: HRESULT_FROM_WIN32 in hresultcategory is a function and does not evaluate to a constant expression
2 participants
@michaelKle @rikyoz