Fix startstop lambda has no effect on desire count #35
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -35,7 +35,7 @@ const ec2Client = new EC2Client({ region: REGION }); | |||
| /** | |||
| * Everything here has the assumption there is only one task. | |||
| */ | |||
| const handler: APIGatewayProxyHandler = async (event: APIGatewayEvent, context: Context) => { | |||
| export const handler: APIGatewayProxyHandler = async (event: APIGatewayEvent, context: Context) => { | |||
There was a problem hiding this comment.
Lets specify the return type to clarify the required response values: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/trigger/api-gateway-proxy.d.ts#L140-L154
| console.log("request: " + JSON.stringify(event)); | ||
| let responseCode = 400; | ||
| let message = "authentication failed"; | ||
| export const handler: APIGatewayProxyHandler = async (event: APIGatewayEvent, context: Context) => { |
There was a problem hiding this comment.
Same as before, wrt specifying the return type: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/trigger/api-gateway-proxy.d.ts#L140-L154
|
|
||
| if (event.queryStringParameters && event.queryStringParameters.key) { | ||
| let key = event.queryStringParameters.key; | ||
| if (key == PASSWORD) { |
There was a problem hiding this comment.
Just realized, this should be ===
Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness
| // property to 'true'. | ||
| return { | ||
| statusCode: responseCode, | ||
| headers: {}, |
There was a problem hiding this comment.
Not needed, and the comment above is redundant if the handler response is strongly typed
| await client.send(updateCommand).then( | ||
| (data) => { | ||
| console.log(`OK! ${JSON.stringify(data, null, 2)}`); | ||
| }, | ||
| (err) => { | ||
| console.log(`Error! ${JSON.stringify(err, null, 2)}`); |
There was a problem hiding this comment.
I would refactor this to be pure async/await:
try {
const result = await client.send(updateCommand);
console.log(`OK! ${JSON.stringify(result, null, 2)}`);
} catch (error) {
console.log(`Error! ${JSON.stringify(error, null, 2)}`);
}
This resolves issue #34