Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix compatibility with Visual Studio 2019 #1

Closed
wants to merge 1 commit into from

Conversation

chenxiaolong
Copy link

This adds a missing <codecvt> include and switches switches from auto_ptr to unique_ptr.

This doesn't completely allow the project to be built with VS2019. ldid also needs to target C++17 and use std::filesystem instead of std::experimental::filesystem. I didn't include this change in the PR because I'm not sure if it'll break compilation with earlier versions of MSVC.

diff --git a/ldid/ldid.cpp b/ldid/ldid.cpp
index 3e30220..de7b61f 100755
--- a/ldid/ldid.cpp
+++ b/ldid/ldid.cpp
@@ -70,7 +70,7 @@
 
 #include <filesystem>
 
-namespace fs = std::experimental::filesystem;
+namespace fs = std::filesystem;
 
 #ifdef __APPLE__
 #include <CommonCrypto/CommonDigest.h>
diff --git a/ldid/ldid.vcxproj b/ldid/ldid.vcxproj
index f23c5fe..3c72e39 100755
--- a/ldid/ldid.vcxproj
+++ b/ldid/ldid.vcxproj
@@ -107,7 +107,7 @@
       <ConformanceMode>true</ConformanceMode>
       <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
       <AdditionalIncludeDirectories>$(ProjectDir)..\Dependencies\dirent\include;$(ProjectDir)..\Dependencies\libimobiledevice-vs\libplist\include;$(ProjectDir)..\AltSign\Dependencies\regex\include;$(ProjectDir)..\AltSign\Dependencies\mman;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <LanguageStandard>stdcpp14</LanguageStandard>
+      <LanguageStandard>stdcpp17</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>

Signed-off-by: Andrew Gunnerson <andrewgunnerson@gmail.com>
@ghost
Copy link

ghost commented Dec 29, 2019

Sir, can you please share build instructions? I am very stuck

@lonkelle
Copy link
Collaborator

lonkelle commented Jul 2, 2021

@rileytestut Do you use VS 2019 to compile AltServer for Windows? Is this worth looking into - someone did approve it on Feb 2nd of this year.

@lonkelle
Copy link
Collaborator

lonkelle commented Jul 2, 2021

Imma just close it for now since this conflicts anyway now.

@lonkelle lonkelle closed this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants