Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support iOS 13+ dark mode #82

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

ericlewis
Copy link
Collaborator

@ericlewis ericlewis commented Nov 6, 2020

Description

This PR enables iOS dark mode support. It does not affect any views that clearly were intended to be only dark nor any accent colors that were against non-changing color schemes (i.e. pause menu). Settings and all it's children views as well as the cheats screens have been updated.

Opinions

Alert Boxes & action sheets, however, do pick up on the system color. I personally like this, but we could force them to be brighter as well.

Testing

  • I am aware that Initial support for iPad and iOS 13 system colors. #18 exists, but this is a more focused and testable approach to ensuring that we get the colors at least right.
  • I have tested every screen that I touched to also ensure it works correctly.
  • I have tested against iOS 12.2 (min supported version) with everything looking great.

Screenshots

Light Dark
Light Dark

@ericlewis
Copy link
Collaborator Author

this could probably serve as a good basis for how difficult it is to switch to an entire custom theming method too.

Copy link
Owner

@rileytestut rileytestut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the small PR, everything looks good to me 👍 Thanks so much for doing this!

@rileytestut rileytestut merged commit 8a273b3 into rileytestut:develop Nov 6, 2020
Copy link

@hmzbg hmzbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kfgkkk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants