-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Super Pill and Range Picker #4422
base: main
Are you sure you want to change the base?
Conversation
As mentioned in check-in, first @mindspank will review the UX. After his green light, one of @AdityaHegde / @djbarnwal / myself will do the code review. |
Code looks good. I see @jkhwu just finalized the Time "Superpill" PRD, so I think her UX feedback will be important. |
https://www.notion.so/rilldata/UXQA-Time-superpill-d7ed5d224f4e4a829bf588eb3ee27d82?pvs=4 |
Adding some comments to the same list |
@ericpgreen2 @briangregoryholmes Are we splitting timeseries exports into its own issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kapture.2024-05-22.at.15.22.49.mp4
The date picker does not work as expected for me. It gives me the full date range for my timezone (IST) but for other timezones, it again gives me the range according to IST.
UXQA –
|
Hi y'all, I've done a Product Review and documented my thoughts here: https://www.notion.so/rilldata/EO-Product-Review-notes-25f671118e0f4bc7a1bd6073091581ab?pvs=4 @jkhwu @medriscoll, we'll probably need to chat separately on my feedback before @briangregoryholmes can start work as it's mostly UX-focused |
This PR incorporates a variety of updates related to the new Time Super Pill. It started as a refactor of the calendar picker, the original description of which can be seen below.
This implementation has been put together with the Time Control store refactor in mind, but sticks to the existing state, pulling only a few helpers or types from the new time controls file. As such, a few things that have just been copied verbatim into new locations will be simplified when integrated with the new store.
To Do:
Out of Scope:
This PR is a feature-complete, but WIP proposal (initially started with #3824) that both updates the
TimeRangeSelector
andTimeComparisonSelector
menus to the new ShadCN components and makes a related and technically necessary change to our date picker implementation. Additionally, there is some simplification being done in preparation for the refactor of the time control state management.Looking for experience passes around the new UX, technical review (mostly around date handling), design input and general feedback.
Month
andCalendar
componentsSelect
components from ShadCNTagging @mindspank and @jkhwu
Closes: #3808