-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Global dimension search in metrics view in both rill dev and cloud #4905
Conversation
9d90695
to
551100d
Compare
3c0dd7a
to
a8a9807
Compare
a8a9807
to
6f6fd08
Compare
f44cad1
to
4f75531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks pretty good!
UXQA –
- If a search query errored, we should say so and maybe give the user the option to retry the specific query/queries. Here I received "context deadline exceeded" when searching against a Druid-backed dashboard.
- There's very poor performance when searching Druid-backed dashboards. Mind opening up a conversation with Platform to confirm the batch query approach, or if they recommend a different query pattern?
- It'd be nice to submit the form after a pause in typing. If so, subsequent typing should cancel an outstanding request.
- On an Adbids dashboard in Rill Developer, I searched for "facebook" and the search never finished searching the
Domain
dimension. I see the below error in my browser console.
- When a dimension value is already set as a dashboard filter, it'd be nice if there were an indicative checkmark in the search results.
- For parity with the Enterprise application, the previous search input text should be retained when re-opening the search box.
- In Rill Developer, the search button should be to the left of the Deploy & Edit Metrics buttons.
- Nit: When there are no results yet, there shouldn't be the extra empty bottom section below the
DropdownMenuSeparator
.
- Nit: I'd expect the progress bar to disappear after reaching 100%
- Nit: After using the down arrow key to focus on the first menu item, I'd like the up arrow key to re-focus on the search input.
As mentioned in the demo, let's add a feature flag for this so that we can iterate on the Druid performance in a follow-on PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming this package-lock.json
modification is intended? I'm not seeing any package.json
changes in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Will revert
Merging this behind a feature flag: |
closes #4882
This adds a search button at the top right corner for both rill dev and cloud.