rilmodem: Fix SIM Pin handling regression (LP: #1363413) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function __ofono_sim_recheck_pin() was being called before the sim_status_cb() function set the new passwd_state. This caused enter-pin operations to fail the first time.
|
Looks ok. Unfortunately I lack rights to approve it |
|
OK, we can sort that merge rights next week when Alfonso returns. Thanks for the review, and I will go ahead and merge. |
tonyespy
added a commit
that referenced
this pull request
Sep 4, 2014
rilmodem: Fix SIM Pin handling regression (LP: #1363413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function __ofono_sim_recheck_pin() was being called before
the sim_status_cb() function set the new passwd_state. This
caused enter-pin operations to fail the first time.
This has been tested on krillin running rtm image #9.